felixcheung commented on a change in pull request #3306: [ZEPPELIN-4001] 
zeppelin-interpreter-integration is ignored due to wrong folder structure
URL: https://github.com/apache/zeppelin/pull/3306#discussion_r256712964
 
 

 ##########
 File path: 
spark/interpreter/src/main/java/org/apache/zeppelin/spark/SparkVersion.java
 ##########
 @@ -86,7 +86,7 @@ public boolean isSpark2() {
   }
 
   public boolean isSecretSocketSupported() {
-    return this.newerThanEquals(SPARK_2_3_1);
+    return this.newerThanEquals(SPARK_2_3_1) || 
this.equals(SparkVersion.fromVersionString("2.1.2"));
 
 Review comment:
   I don't think we should hardcode this? why not newerThanEquals(SPARK_2_1_2)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to