Making a new branch make sense to me, if no objection, I will create a branch for you.
Jongyoul Lee <jongy...@gmail.com> 于2019年3月31日周日 下午12:29写道： > Hi, > > Basically, all PRs should be merged separately in a master branch. By the > same rule, if you have a big task which has several small tasks, all sub > tasks should be reviewed and merged separately with a complete small > function, even if it changes some behaviors. > > Making branches help sometimes for some contributors but on the other > hand, it might not have a chance to be reviewed by others. > > Regards, > JL > > On Sun, Mar 31, 2019 at 12:48 Xun Liu <liuxun...@gmail.com> wrote: > >> HI，Zeppelin PMC >> >> I am a contributor to zeppelin Xun Liu. >> When I was doing Zeppelin in GSOC 2019, A problem I can't solve, Who can >> help me? >> Two students (HOMAGNI GHOSH & Basil Morkovkin) selected zeppelin workflow >> as their GSOC 2019 project. >> JIRA： https://issues.apache.org/jira/browse/ZEPPELIN-4018 >> >> I keep in touch with them by email because workflow is a big feature. >> Some sub-tasks should be created to do this. >> >> Now that we have a function, we need to submit the code, >> Where should their code be submitted? >> >> These two students asked their questions, >> I feel obligated to report back to you. >> I think it's creating a development branch in zeppelin, >> Code for merging them, >> After all workflow has been developed and passed the system test, >> And then merge it into the master branch. >> What do you think? >> >> >> ---------- Forwarded message --------- >> 发件人： Morkovkin, Basil <morkovkin...@phystech.edu> >> Date: 2019年3月29日周五 下午9:26 >> Subject: Submitting code >> To: Xun Liu <liuxun...@gmail.com> >> >> >> Hi! I have an organization question: how do we submit the code for >> sub-tasks of ZEPPELIN-4018? Will we gather all the code in a separate >> branch until all features are implemented or just gather all in the master >> branch? >> >> >> :) >> >> -------------------------------- >> Best regards, Basil Morkovkin >> > -- > 이종열, Jongyoul Lee, 李宗烈 > http://madeng.net > -- Best Regards Jeff Zhang
