Hi! When can I create a branch to submit the code solving https://issues.apache.org/jira/plugins/servlet/mobile#issue/ZEPPELIN-4018 ?
On Mon, Apr 1, 2019, 4:50 AM Xun Liu <liuxun...@gmail.com> wrote: > I thought about it, it is. > > We create a development branch, This development branch, > All submission specifications that conform to the airship code are still > required. > > Just added a help. After this feature is developed, > It is possible to let everyone see the effect of this function through > video. > You can rearrange all the code in this function. > Let the code merge better into the main branch. > > Felix Cheung <felixcheun...@hotmail.com> 于2019年4月1日周一 上午1:56写道： > >> Wait wait. Please clarify the goal of the branch? If it is just for “many >> big changes that might not be stable enough for master” the I’m for it. But >> we must follow the current process of PR, review, test for each PR or >> merge. By committers that has write access to the repo, for each PR. And as >> Jongyoul said, smaller PR that are complete makes it easier. Some test >> infra might have problem testing non master branche though. >> >> So to clarify, if the goal is fast development or >> experimental/incomplete changes then this will not be it. If that is the >> case please consider what I’ve suggested. Fork the repo, then share access. >> Open PR to merge bigger complete chunk when ready. This has been done many >> times in other projects. >> >> >> ------------------------------ >> *From:* Xun Liu <liuxun...@gmail.com> >> *Sent:* Sunday, March 31, 2019 8:12 AM >> *To:* Jongyoul Lee >> *Cc:* Felix Cheung; H GHOSH; Jeff Zhang; Morkovkin, Basil; dev; moon soo >> Lee >> *Subject:* Re: Submitting code >> >> Hi >> >> I agree to create an independent development branch. >> This branch is only used to develop the workflow feature. >> This ensures that the master branch code is not corrupted. >> >> I will be with the HOMAGNI GHOSH & Basil Morkovkin, >> Often rebase this branch to the master, >> Keep the branch of workflow as up to date as possible. >> >> Jongyoul Lee <jongy...@gmail.com> 于2019年3月31日周日 下午11:04写道： >> >>> Hello, >>> >>> If this work doesn’t block any others, I agree with making a develop >>> branch. BTW, is it possible to give permissions to non-committers against >>> some branches under the apache/zeppelin? >>> >>> JL >>> >>> On Sun, Mar 31, 2019 at 18:17 Xun Liu <liuxun...@gmail.com> wrote: >>> >>>> Thank you very much for your prompt reply. >>>> >>>> In the Basil Morkovkin additional email, Basil Morkovkin proposed the >>>> idea of optimizing zeppelin's Scheduler.java. >>>> So the development of workflow, It is possible to refactor some of the >>>> code and processes of zeppelin. >>>> So I suggest also creating a development branch for workflow. >>>> I am developing with HOMAGNI GHOSH & Basil Morkovkin on this branch. >>>> All functions are developed, We will record a very detailed operation >>>> video. >>>> After everyone’s approval, Let's put the code in this development >>>> branch again. >>>> According to the consolidation of the ticket one by one into the master >>>> trunk branch. >>>> >>>> Because I am not familiar with the open source community workflow, >>>> So it brings some confusion to HOMAGNI GHOSH & Basil Morkovkin. >>>> I feel very sorry. I will work hard to assist HOMAGNI GHOSH & Basil >>>> Morkovkin in the development of Workflow. >>>> >>>> Jeff, please help me create a development branch called Workflow. Thank >>>> you! >>>> :-) >>>> >>>> Jeff Zhang <zjf...@gmail.com> 于2019年3月31日周日 下午1:46写道： >>>> >>>>> Making a new branch make sense to me, if no objection, I will create a >>>>> branch for you. >>>>> >>>>> >>>>> Jongyoul Lee <jongy...@gmail.com> 于2019年3月31日周日 下午12:29写道： >>>>> >>>>>> Hi, >>>>>> >>>>>> Basically, all PRs should be merged separately in a master branch. By >>>>>> the same rule, if you have a big task which has several small tasks, all >>>>>> sub tasks should be reviewed and merged separately with a complete small >>>>>> function, even if it changes some behaviors. >>>>>> >>>>>> Making branches help sometimes for some contributors but on the other >>>>>> hand, it might not have a chance to be reviewed by others. >>>>>> >>>>>> Regards, >>>>>> JL >>>>>> >>>>>> On Sun, Mar 31, 2019 at 12:48 Xun Liu <liuxun...@gmail.com> wrote: >>>>>> >>>>>>> HI，Zeppelin PMC >>>>>>> >>>>>>> I am a contributor to zeppelin Xun Liu. >>>>>>> When I was doing Zeppelin in GSOC 2019, A problem I can't solve, Who >>>>>>> can help me? >>>>>>> Two students (HOMAGNI GHOSH & Basil Morkovkin) selected zeppelin >>>>>>> workflow as their GSOC 2019 project. >>>>>>> JIRA： https://issues.apache.org/jira/browse/ZEPPELIN-4018 >>>>>>> >>>>>>> I keep in touch with them by email because workflow is a big feature. >>>>>>> Some sub-tasks should be created to do this. >>>>>>> >>>>>>> Now that we have a function, we need to submit the code, >>>>>>> Where should their code be submitted? >>>>>>> >>>>>>> These two students asked their questions, >>>>>>> I feel obligated to report back to you. >>>>>>> I think it's creating a development branch in zeppelin, >>>>>>> Code for merging them, >>>>>>> After all workflow has been developed and passed the system test, >>>>>>> And then merge it into the master branch. >>>>>>> What do you think? >>>>>>> >>>>>>> >>>>>>> ---------- Forwarded message --------- >>>>>>> 发件人： Morkovkin, Basil <morkovkin...@phystech.edu> >>>>>>> Date: 2019年3月29日周五 下午9:26 >>>>>>> Subject: Submitting code >>>>>>> To: Xun Liu <liuxun...@gmail.com> >>>>>>> >>>>>>> >>>>>>> Hi! I have an organization question: how do we submit the code for >>>>>>> sub-tasks of ZEPPELIN-4018? Will we gather all the code in a separate >>>>>>> branch until all features are implemented or just gather all in the >>>>>>> master >>>>>>> branch? >>>>>>> >>>>>>> >>>>>>> :) >>>>>>> >>>>>>> -------------------------------- >>>>>>> Best regards, Basil Morkovkin >>>>>>> >>>>>> -- >>>>>> 이종열, Jongyoul Lee, 李宗烈 >>>>>> http://madeng.net >>>>>> >>>>> >>>>> >>>>> -- >>>>> Best Regards >>>>> >>>>> Jeff Zhang >>>>> >>>> -- >>> 이종열, Jongyoul Lee, 李宗烈 >>> http://madeng.net >>> >>
