Leemoonsoo commented on a change in pull request #3240: [ZEPPELIN-3840] Zeppelin on Kubernetes URL: https://github.com/apache/zeppelin/pull/3240#discussion_r280916925
########## File path: zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/Kubectl.java ########## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.zeppelin.interpreter.launcher; + +import com.google.common.annotations.VisibleForTesting; +import com.google.gson.Gson; +import java.util.ArrayList; +import java.util.Arrays; + +import org.apache.commons.exec.*; +import org.apache.commons.io.IOUtils; + +import java.io.*; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class Kubectl { + private final Logger LOGGER = LoggerFactory.getLogger(Kubectl.class); + private final String kubectlCmd; + private final Gson gson = new Gson(); + private String namespace; + + public Kubectl(String kubectlCmd) { + this.kubectlCmd = kubectlCmd; + } + + /** + * Override namespace. Otherwise use namespace provided in schema + * @param namespace + */ + public void setNamespace(String namespace) { + this.namespace = namespace; + } + + public String getNamespace() { + return namespace; + } + + public String apply(String spec) throws IOException { + return execAndGet(new String[]{"apply", "-f", "-"}, spec); + } + + public String delete(String spec) throws IOException { + return execAndGet(new String[]{"delete", "-f", "-"}, spec); + } + + public String wait(String resource, String waitFor, int timeoutSec) throws IOException { + try { + return execAndGet(new String[]{ + "wait", + resource, + String.format("--for=%s", waitFor), + String.format("--timeout=%ds", timeoutSec)}); + } catch (IOException e) { + if ("delete".equals(waitFor) && e.getMessage().contains("NotFound")) { + LOGGER.info("{} Not found. Maybe already deleted.", resource); + return ""; + } else { + throw e; + } + } + } + + public ExecuteWatchdog portForward(String resource, String [] ports) throws IOException { + DefaultExecutor executor = new DefaultExecutor(); + CommandLine cmd = new CommandLine(kubectlCmd); + cmd.addArguments("port-forward"); + cmd.addArguments(resource); + cmd.addArguments(ports); + + ExecuteWatchdog watchdog = new ExecuteWatchdog(-1); + executor.setWatchdog(watchdog); + + executor.execute(cmd, new ExecuteResultHandler() { + @Override + public void onProcessComplete(int i) { + LOGGER.info("Port-forward stopped"); + } + + @Override + public void onProcessFailed(ExecuteException e) { + LOGGER.debug("port-forward process exit", e); + } + }); + + return watchdog; + } + + String execAndGet(String [] args) throws IOException { + return execAndGet(args, ""); + } + + @VisibleForTesting + String execAndGet(String [] args, String stdin) throws IOException { + InputStream ins = IOUtils.toInputStream(stdin); + ByteArrayOutputStream stdout = new ByteArrayOutputStream(); + ByteArrayOutputStream stderr = new ByteArrayOutputStream(); + ArrayList<String> argsToOverride = new ArrayList<>(Arrays.asList(args)); + + // set namespace + if (namespace != null) { + argsToOverride.add("--namespace=" + namespace); + } + + LOGGER.info("kubectl " + argsToOverride); + LOGGER.debug(stdin); + + try { + int exitCode = execute( + argsToOverride.toArray(new String[0]), + ins, + stdout, + stderr + ); + + if (exitCode == 0) { + String output = new String(stdout.toByteArray()); + return output; + } else { + String output = new String(stderr.toByteArray()); + throw new IOException(String.format("non zero return code (%d). %s", exitCode, output)); + } + } catch (Exception e) { + String output = new String(stderr.toByteArray()); + throw new IOException(output, e); + } + } + + public int execute(String [] args, InputStream stdin, OutputStream stdout, OutputStream stderr) throws IOException { + DefaultExecutor executor = new DefaultExecutor(); + CommandLine cmd = new CommandLine(kubectlCmd); + cmd.addArguments(args); + + ExecuteWatchdog watchdog = new ExecuteWatchdog(60 * 1000); Review comment: Thanks for pointing it out! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
