zjffdu commented on issue #3372: [ZEPPELIN-3623] Create interpreter process in the cluster mode URL: https://github.com/apache/zeppelin/pull/3372#issuecomment-497620777 @liuxunorg Thanks for the PR. I left a few comments. Overall I don't think it is proper to do it in injection approach. A lots of cluster deployment specific logic is injected into Interpreter, RemoteInterpreterServer and etc. I think cluster deployment is another kind of launch approach, we should move them out of the standard interpreter classes to make them decouple of these basic classes.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
