zjffdu commented on a change in pull request #3389: [ZEPPELIN-4209] Fixed the
ClusterInterpreterLauncher can not listen cluster events
URL: https://github.com/apache/zeppelin/pull/3389#discussion_r299520510
##########
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java
##########
@@ -210,6 +211,18 @@ private void initInterpreterSetting(InterpreterSetting
interpreterSetting) {
.setRecoveryStorage(recoveryStorage)
.setInterpreterEventServer(interpreterEventServer)
.postProcessing();
+
+ // Since the ClusterInterpreterLauncher is lazy, dynamically generated, So
in cluster mode,
+ // when the zeppelin service starts, Create a ClusterInterpreterLauncher
object,
+ // This allows the ClusterInterpreterLauncher to listen for cluster events.
+ if (conf.isClusterMode()) {
+ try {
+ String pluginName = interpreterSetting.getLauncherPlugin();
+ PluginManager.get().loadInterpreterLauncher(pluginName,
recoveryStorage);
Review comment:
Why init IntepreterLauncher here instead of InterpreterSetting ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
