felixcheung commented on a change in pull request #3400: [ZEPPELIN-4217].
Remove semicolon at the end of sql statement for JdbcInterpreter
URL: https://github.com/apache/zeppelin/pull/3400#discussion_r302164253
##########
File path: jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
##########
@@ -713,6 +713,9 @@ private InterpreterResult executeSql(String propertyKey,
String sql,
if (splitQuery) {
sqlArray = splitSqlQueries(sql);
} else {
+ if (sql.trim().endsWith(";")) {
+ sql = sql.trim().substring(0, sql.trim().length() - 1);
+ }
Review comment:
nit: why not sql.trim() in all other cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
