felixcheung commented on a change in pull request #3407: [ZEPPELIN-4240] Fixed
the date format error in cluster management page
URL: https://github.com/apache/zeppelin/pull/3407#discussion_r303720470
##########
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/rest/ClusterRestApi.java
##########
@@ -152,8 +160,15 @@ public Response getClusterNodes(){
return new JsonResponse(Response.Status.OK, "", nodes).build();
}
- private String formatIntpLink(String intpName) {
- return String.format("<a href=\"/#/cluster/%s\">%s</a>", intpName,
intpName);
+ private String formatDateTime(Object localDateTime) {
Review comment:
i think the function should be strongly types? one approach is `private
String formatDateTime(LocalDateTime localDateTime)`
and then `String dateTime = formatDateTime((LocalDateTime)serverStartTime);`
I think this will be more maintainable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
