Reamer commented on a change in pull request #3429: [ZEPPELIN-4306] Add
ForwardedRequestCustomizer to httpConfig
URL: https://github.com/apache/zeppelin/pull/3429#discussion_r319744445
##########
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java
##########
@@ -295,9 +296,10 @@ private static Server
setupJettyServer(ZeppelinConfiguration conf) {
final Server server = new Server(threadPool);
ServerConnector connector;
+ HttpConfiguration httpConfig = new HttpConfiguration();
+ httpConfig.addCustomizer(new ForwardedRequestCustomizer());
Review comment:
No it's not needed, when you doesn't use a proxy. Without a Proxy (e.g.
SSL-Offload-Proxy)[`ForwardedRequestCustomizer`](https://www.eclipse.org/jetty/javadoc/9.4.8.v20171121/org/eclipse/jetty/server/ForwardedRequestCustomizer.html)
has no impact, because the HTTP-Headers (`X-Forwarded-For`,
`X-Forwarded-Proto` and so on) are missing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
