zjffdu commented on a change in pull request #3430: [ZEPPELIN-4312] enable livy
to run as remote interpreter in docker
URL: https://github.com/apache/zeppelin/pull/3430#discussion_r329919270
##########
File path:
zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterProcess.java
##########
@@ -416,14 +417,18 @@ private void copyRunFileToContainer(String containerId)
intpKeytab = properties.getProperty("submarine.hadoop.keytab", "");
}
if (StringUtils.isBlank(intpKeytab)) {
- // 3.4) jdbc interpreter properties keytab file
+ // 3.4) livy interpreter properties keytab file
+ intpKeytab = properties.getProperty("zeppelin.livy.keytab", "");
+ }
+ if (StringUtils.isBlank(intpKeytab)) {
+ // 3.5) jdbc interpreter properties keytab file
Review comment:
I am fine with current implementation also not so elegant. Maybe in future
we should consider about a general property for interpreter keytab, e.g.
`zeppelin.interpreter.keytab`. But it is beyond the scope of this PR, and could
be done in another ticket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
