primerano commented on a change in pull request #3466: [Zeppelin-4341] fix role
setting when using multiple realms
URL: https://github.com/apache/zeppelin/pull/3466#discussion_r332641216
##########
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/realm/LdapRealm.java
##########
@@ -329,8 +329,8 @@ private boolean
hasAllowedAuthenticationRules(PrincipalCollection principals,
systemLdapCtx = ldapContextFactory.getSystemLdapContext();
return rolesFor(principals, username, systemLdapCtx,
ldapContextFactory, SecurityUtils.getSubject().getSession());
- } catch (AuthenticationException ae) {
- ae.printStackTrace();
+ } catch (Throwable t) {
+ t.printStackTrace();
Review comment:
@zjffdu i wondered if there was a reason it was printing the stack trace.
log.error makes more sense. i'll change it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
