AyWa edited a comment on issue #3336: [ZEPPELIN-4091] Fix concurrent 
autocomplete and execute for Ipython
URL: https://github.com/apache/zeppelin/pull/3336#issuecomment-475549925
 
 
   I am kind of lost with the test:
   - I ran my fix, without the new test -> all the test pass on the ci
   - I ran my fix, with the new test - > always some failure (seems like `GC` 
or out of memory or timeout)
   - I ran my fix, with a test, that is not testing the fix (like no concurrent 
call) -> fail again
   
   So i think the problem is not related to the fix itself, but more like an 
issue with the test:
   - `ExecutorService pool = Executors.newFixedThreadPool(2);` make the `GC / 
OOM`  ?
   - running then auto complete make some issue ? 
   
   I will try to push the same code without executor / thread to see if it is 
working, then try to thread it again :/ 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to