zjffdu edited a comment on issue #3490: [ZEPPELIN-4321] Rework Zeppelin with Latest Angular URL: https://github.com/apache/zeppelin/pull/3490#issuecomment-545822569 Thanks @hsuanxyz . Here's my comments: 1. In the PR description, the `Note` column in table should be renamed to `Description` 2. Does `package-lock.json` need to be committed ? https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5 Besides that, could you list your plan after this PR ? One important task is adding this into travis build so and add integration test ? The examples you listed in PR description is pretty helpful, especially when we could add them into integration instead of manually tested them each time.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
