zjffdu commented on issue #3480: [ZEPPELIN-3644] SPARQL-Interpreter support via 
Apache Jena ARQ
URL: https://github.com/apache/zeppelin/pull/3480#issuecomment-548634503
 
 
   > > Thanks for the contribution @hsteinmueller , this PR LGTM, could you 
paste the travis build link ?
   > 
   > https://travis-ci.org/hsteinmueller/zeppelin
   > 
   > > IIUC, `jena` is one implementation of `sparql`. Since interpreter text 
`%sparql` is user facing, I would prefer to configure the implementation of 
`sparql` in interpreter setting instead of via interpreter text.
   > 
   > Do you want me to update the interpreter settings with this functionality 
or will this be changed once another implementation gets added?
   
   I mean to use interpreter setting to choose which implementation.  e.g. Add 
interpreter setting `sparql.type`.  IIUC, user don't care about the 
implementation of sparql ( I may be wrong ), only administrator care about 
that, so we should put ti in interpreter setting which is often maintained by 
administrator. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to