ileasile commented on a change in pull request #3440: [ZEPPELIN-4323] Kotlin support for Spark interpreter URL: https://github.com/apache/zeppelin/pull/3440#discussion_r344151750
########## File path: kotlin/src/main/java/org/apache/zeppelin/kotlin/reflect/KotlinFunctionInfo.java ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.zeppelin.kotlin.reflect; + +import static org.apache.zeppelin.kotlin.reflect.KotlinReflectUtil.functionSignature; +import static org.apache.zeppelin.kotlin.reflect.KotlinReflectUtil.shorten; +import org.jetbrains.annotations.NotNull; +import kotlin.reflect.KFunction; + +public class KotlinFunctionInfo implements Comparable<KotlinFunctionInfo> { + private final KFunction<?> function; + + public KotlinFunctionInfo(KFunction<?> function) { + this.function = function; + } + + public KFunction<?> getFunction() { + return function; + } + + public String getName() { + return function.getName(); + } + + public String toString(boolean shortenTypes) { + if (shortenTypes) { + return shorten(toString()); + } + return toString(); + } + + @Override + public String toString() { + return functionSignature(function); + } + + @Override + public int compareTo(@NotNull KotlinFunctionInfo f) { + return this.toString().hashCode() - f.toString().hashCode(); Review comment: `return this.toString().compareTo(f.toString());` seems to be more correct. Equality of hash codes doesn't guarantee that objects are equal (though the opposite is true). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
