malayhm commented on issue #3516: Zeppelin-4383 Notebook Permalink Support
URL: https://github.com/apache/zeppelin/pull/3516#issuecomment-554515139
 
 
   @zjffdu 
   
   Before this PR, there was no permalink support in vue.js implementation.
    > Is the note link not permalink before this PR ?
   
   Today, we have http://localhost:8080/#/notebook/<note_id> as permalink in 
Angular implementation, but with vue implementation, it will be 
http://localhost:8080/#/<note_id>.
   Should we change it to http://localhost:8080/#/notebook/<note_id> in this PR 
as well?
    > Is the note link the same as now ?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to