amakaur commented on issue #3502: [ZEPPELIN-4413] Added a close note button on 
zepp ui to shut down sc and release roso…
URL: https://github.com/apache/zeppelin/pull/3502#issuecomment-559904916
 
 
   @zjffdu 1. We're already using TimeoutLifecycleManager to release the 
resources automatically after 1 hour, but there's an issue with closing 
notebook this way where 
https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/ManagedInterpreterGroup.java#L88
 `close(sessionId)` wouldn't get triggered for some of the notebooks randomly 
and spark context would be alive for couple of days until zeppelin is restarted 
or notebook is closed using the feature in this PR. 
   
   Also, we would like the ability to close the notebook at any moment without 
depending on the timeout.
   
   2. Restarting the interpreter causes notebooks to get stuck in a pending 
state a lot of the times. So this helps to completely shut down the spark 
context and bring back the notebook in a fresh clean state.
   
   3. This is similar to https://github.com/apache/zeppelin/pull/3501 but 
requires less work from the user to close the note. This makes it easy for any 
user to reset the state of their notebook.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to