zjffdu commented on a change in pull request #3615: [ZEPPELIN-4574] Fixed
rootNotebookFolder and noteFileName in VFSNotebookRepo.java to allow it to work
on windows
URL: https://github.com/apache/zeppelin/pull/3615#discussion_r368977359
##########
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepo.java
##########
@@ -88,7 +88,7 @@ protected void setNotebookDirectory(String notebookDirPath)
throws IOException {
LOGGER.info("Notebook dir doesn't exist: {}, creating it.",
rootNotebookFileObject.getName().getPath());
}
- this.rootNotebookFolder = rootNotebookFileObject.getName().getPath();
+ this.rootNotebookFolder =
rootNotebookFileObject.getName().getURI().replace("file:///", "/");
Review comment:
Do you mind to add some comment on this change to help others understand why
call `getURI().replace("file:///", "/")`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
