javierivanov opened a new pull request #3622: [ZEPPELIN-4586] Add option to avoid sending Jetty version on headers and on 300/400 pages URL: https://github.com/apache/zeppelin/pull/3622 ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html ### What type of PR is it? [Improvement] ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4586 ### How should this be tested? * Travis should pass With default`zeppelin.server.send.jetty.name = true` ``` $ curl -i localhost:8080/nonexisting HTTP/1.1 404 Not Found Date: Fri, 31 Jan 2020 19:16:33 GMT Access-Control-Allow-Credentials: true Access-Control-Allow-Headers: authorization,Content-Type Access-Control-Allow-Methods: POST, GET, OPTIONS, PUT, HEAD, DELETE X-FRAME-OPTIONS: SAMEORIGIN X-XSS-Protection: 1 X-Content-Type-Options: nosniff Cache-Control: must-revalidate,no-cache,no-store Content-Type: text/html;charset=iso-8859-1 Content-Length: 328 Server: Jetty(9.4.18.v20190429) <html> <head> <meta http-equiv="Content-Type" content="text/html;charset=utf-8"/> <title>Error 404 Not Found</title> </head> <body><h2>HTTP ERROR 404</h2> <p>Problem accessing /nonexisting. Reason: <pre> Not Found</pre></p><hr><a href="http://eclipse.org/jetty";>Powered by Jetty:// 9.4.18.v20190429</a><hr/> </body> </html> ``` By changing to false `zeppelin.server.send.jetty.name = false` ``` $ curl -i localhost:8080/nonexisting HTTP/1.1 404 Not Found Date: Fri, 31 Jan 2020 19:15:57 GMT Access-Control-Allow-Credentials: true Access-Control-Allow-Headers: authorization,Content-Type Access-Control-Allow-Methods: POST, GET, OPTIONS, PUT, HEAD, DELETE X-FRAME-OPTIONS: SAMEORIGIN X-XSS-Protection: 1 X-Content-Type-Options: nosniff Cache-Control: must-revalidate,no-cache,no-store Content-Type: text/html;charset=iso-8859-1 Content-Length: 243 <html> <head> <meta http-equiv="Content-Type" content="text/html;charset=utf-8"/> <title>Error 404 Not Found</title> </head> <body><h2>HTTP ERROR 404</h2> <p>Problem accessing /nonexisting. Reason: <pre> Not Found</pre></p> </body> </html> ``` ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
