jeff-hammel-leapyear commented on issue #3618: [ZEPPELIN-4580] check the instance type rather than the class name URL: https://github.com/apache/zeppelin/pull/3618#issuecomment-585960763 @zjffdu there do not seem to be any changes on this branch: ``` λ git rebase branch-0.8 Current branch jeff/knox_instanceof is up to date. ``` I have verified this by correlating `git log` with https://github.com/apache/zeppelin/tree/branch-0.8 ``` commit 3909846f8d84aac98df8d881d10472253e79ef54 (HEAD -> jeff/knox_instanceof, origin/jeff/knox_instanceof) Author: Jeff Hammel <[email protected]> Date: Tue Feb 11 09:36:33 2020 -0800 remove now unused references to name commit 00c3d7daed93e0a09c4f64ab8f53adc039d089d3 Author: Jeff Hammel <[email protected]> Date: Thu Jan 23 16:10:34 2020 -0800 check the instance type rather than the class name commit 151118d18a0bd9570eeb889400295e2277285076 (upstream/branch-0.8, origin/branch-0.8, branch-0.8) Author: LeeDongMyeong <[email protected]> Date: Thu Nov 21 14:42:56 2019 +0900 [ZEPPELIN-4449] Fix Credentials update errors ``` Perhaps you would rather have this PR made against master instead? I targeted `branch-0.8` as we are currently maintaining a 0.8 series installation with a custom authenticator.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
