alexott commented on a change in pull request #3672: [ZEPPELIN-4661]. Fail to
run whole note
URL: https://github.com/apache/zeppelin/pull/3672#discussion_r386113899
##########
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java
##########
@@ -376,25 +375,33 @@ public boolean runAllParagraphs(String noteId,
return false;
}
- if (paragraphs == null) {
- paragraphs = gson.fromJson(gson.toJson(note.getParagraphs()), new
TypeToken<List>(){}.getType());
- }
-
note.setRunning(true);
try {
- for (Map<String, Object> raw : paragraphs) {
- String paragraphId = (String) raw.get("id");
- if (paragraphId == null) {
- continue;
+ if (paragraphs != null) {
+ // run note via the data passed from frontend
+ for (Map<String, Object> raw : paragraphs) {
+ String paragraphId = (String) raw.get("id");
+ if (paragraphId == null) {
+ continue;
+ }
+ String text = (String) raw.get("paragraph");
+ String title = (String) raw.get("title");
+ Map<String, Object> params = (Map<String, Object>) raw.get("params");
+ Map<String, Object> config = (Map<String, Object>) raw.get("config");
Review comment:
Should we wrap this into `try`, so if the input data have incorrect type, we
handle this gracefully...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
