alexott commented on a change in pull request #3713: [ZEPPELIN-4718] Fix 
Regression HDFS Notebook Storage
URL: https://github.com/apache/zeppelin/pull/3713#discussion_r402301357
 
 

 ##########
 File path: 
zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
 ##########
 @@ -602,6 +602,10 @@ public boolean isWindowsPath(String path){
     return path.matches("^[A-Za-z]:\\\\.*");
   }
 
+  public boolean isHdfsPath(String path){
+      return path.matches("^hdfs://.*");
+  }
+
 
 Review comment:
   ok, then we can just try to instantiate URI, although we maybe need to wrap 
it in try/catch...
   
   another possibility is to modify regex to match scheme as `scheme://.+`, 
with scheme regex as defined per RFC 3986: `scheme      = ALPHA *( ALPHA / 
DIGIT / "+" / "-" / "." )`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to