alexott commented on a change in pull request #3726: [ZEPPELIN-4735]. Fail to
getCompletion when interpreter doesn't implement completion
URL: https://github.com/apache/zeppelin/pull/3726#discussion_r405401484
##########
File path:
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/Interpreter.java
##########
@@ -156,7 +157,7 @@ public abstract InterpreterResult interpret(String st,
@ZeppelinApi
public List<InterpreterCompletion> completion(String buf, int cursor,
InterpreterContext interpreterContext) throws InterpreterException {
- return null;
+ return new ArrayList<>();
Review comment:
do we need mutable List here? If not, can we use `Collections.emptyList()` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
