zjffdu commented on a change in pull request #3718: [ZEPPELIN-4727] Fix HDFS 
Credentials storage 
URL: https://github.com/apache/zeppelin/pull/3718#discussion_r406652958
 
 

 ##########
 File path: 
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Paragraph.java
 ##########
 @@ -526,13 +526,17 @@ private InterpreterContext getInterpreterContext() {
 
     Credentials credentials = note.getCredentials();
     if (subject != null) {
-      UserCredentials userCredentials =
-          credentials.getUserCredentials(subject.getUser());
+      UserCredentials userCredentials;
+      try {
+        userCredentials = credentials.getUserCredentials(subject.getUser());
+      } catch (IOException e) {
+        LOGGER.error("Unable to get Usercredentials. Working with empty 
UserCredentials", e);
 
 Review comment:
   If we allow to fallback to empty UserCredentials, then I think we should use 
`LOGGER.warn`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to