zjffdu commented on a change in pull request #3732: ZEPPELIN-4747. Terminal
interpreter support internal and external IP mapping
URL: https://github.com/apache/zeppelin/pull/3732#discussion_r407024591
##########
File path:
shell/src/main/java/org/apache/zeppelin/shell/TerminalInterpreter.java
##########
@@ -123,6 +129,13 @@ public InterpreterResult internalInterpret(String cmd,
InterpreterContext contex
}
}
setParagraphConfig();
+ Properties properties = getProperties();
+ String strIpMapping =
properties.getProperty("zeppelin.terminal.ip.mapping");
+ if (!StringUtils.isEmpty(strIpMapping)) {
+ Gson gson = new Gson();
Review comment:
gson could be a static variable so that we don't need to create it for each
call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
