alexott commented on a change in pull request #3717: [ZEPPELIN-4717]. Support
savepoint for insert statement and non-sql paragraph
URL: https://github.com/apache/zeppelin/pull/3717#discussion_r410867087
##########
File path:
flink/src/main/java/org/apache/zeppelin/flink/FlinkSqlInterrpeter.java
##########
@@ -466,34 +478,17 @@ private void callExplain(String sql, InterpreterContext
context) throws IOExcept
public void callSelect(String sql, InterpreterContext context) throws
IOException {
try {
lock.lock();
- // set parallelism from paragraph local property
- if (context.getLocalProperties().containsKey("parallelism")) {
- this.tbenv.getConfig().getConfiguration()
-
.set(ExecutionConfigOptions.TABLE_EXEC_RESOURCE_DEFAULT_PARALLELISM,
-
Integer.parseInt(context.getLocalProperties().get("parallelism")));
- }
-
// set table config from set statement until now.
- for (Map.Entry<String, String> entry : currentConfigOptions.entrySet()) {
+ Map<String, String> paragraphTableConfig =
paragraphTableConfigMap.get(context.getParagraphId());
Review comment:
Above, we used following construct:
```
Map<String, String> tableConfig = paragraphTableConfigMap.getOrDefault(
context.getParagraphId(), new HashMap<>());
```
can we get `null` here? Maybe instead of having direct access
`paragraphTableConfigMap`, we can implement helper function that will guarantee
that we always get Map?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
