Reamer commented on pull request #3752:
URL: https://github.com/apache/zeppelin/pull/3752#issuecomment-620648549


   I think I understand your approach.
   You should change your view. `ZEPPELIN_NOTEBOOK_DIR` should handle the Git 
Root-Directory you should introduce a new variable like 
`ZEPPELIN_NOTEBOOK_GIT_SUB_VIEW`. Use this variable (if set) to concat to the 
folder with is actually viewed in ZeppelinUI. In your example this variable 
should contain `Folder C/ Folder D`
   
   Btw. I'm not the right person to review your change. Maybe @alexott can help 
with this.
   
   Some thoughts.
   I doesn't like the introduced [regular 
expression](https://github.com/apache/zeppelin/pull/3752/files#diff-3d1ddb2389a3d1baf113c60ab996f722R259-R271).
 `/` as a separator is only valid on Unix, what is with Windows? Therefore my 
approach with the sub-path. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to