zjffdu commented on a change in pull request #3794:
URL: https://github.com/apache/zeppelin/pull/3794#discussion_r439983588
##########
File path:
flink/interpreter/src/main/java/org/apache/zeppelin/flink/JobManager.java
##########
@@ -218,15 +222,39 @@ public void run() {
}
}
- public void cancel () {
- this.running.set(false);
- synchronized (running) {
- running.notify();
- }
+ public void cancel() {
+ this.running.set(false);
+ synchronized (running) {
+ running.notify();
}
+ }
- public int getProgress () {
- return progress;
- }
+ public int getProgress() {
+ return progress;
}
}
+
+ static String toRichTimeDuration(long duration) {
+ long days = TimeUnit.SECONDS.toDays(duration);
Review comment:
It seems using Duration doesn't' save work compared current approach, I
still have to get days and minus it from duration, and the same for hours,
minutes, seconds. So I didn't change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
