jason-ogaard opened a new pull request #3864: URL: https://github.com/apache/zeppelin/pull/3864
### What is this PR for? Currently, when the websocket reconnects GET_NOTE is called. The purpose of this call on reconnect is to add the note back to the NoteSocketMap (see discussion here: https://github.com/apache/zeppelin/pull/213). However, GET_NOTE also does two other things: 1. It retrieves the note from storage and 2. Sends that note back to the browser where it is redrawn. Doing this causes issues for our users: 1. The retrieval of the note means that any work done since the note was last saved will be lost. Notes save often, but we've had users complain about this. 2. The redraw causes the cursor to jump back to the beginning of the line. 3. In our environment, the redraw causes the notebook to scroll down. This PR creates a new request that will be called instead of GET_NOTE. The purpose of this new request is to simply put the note back into the NoteSocketMap so that we can continue working. ### What type of PR is it? Improvement ### Todos None ### What is the Jira issue? ### How should this be tested? * Open a notebook, wait for the websocket to reconnect, ensure that you can still do everything you should be able to do. ### Questions: * No * No * No ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
