zjffdu opened a new pull request #3979:
URL: https://github.com/apache/zeppelin/pull/3979


   
   ### What is this PR for?
   
   In the current hive interpreter (jdbc), the line number in the error message 
is not correct, this is due to the logic of how we split sql. In this PR, we 
fix it via
   1. Revert the changes of ZEPPELIN-5135. Because the purpose of ZEPPELIN-5135 
is to get the correct the line number in error message, but it only works in 
single sql statement. This ticket can resolve the issue in all cases (including 
single sql & multiple sql)
   2. Change the logic of `SqlSplitter`, see the SqlSplitterTest for more 
details.
   3. Don't do trim in all the places, otherwise we would get wrong line number.
   
   ### What type of PR is it?
   [ Improvement ]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5138
   
   ### How should this be tested?
   * CI pass & manually tested
   
   ### Screenshots (if appropriate)
   
![image](https://user-images.githubusercontent.com/164491/99874317-f7ed5080-2c21-11eb-9eb4-1ee56cfccb3b.png)
   
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to