Reamer commented on a change in pull request #4007:
URL: https://github.com/apache/zeppelin/pull/4007#discussion_r550853905
##########
File path:
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/KerberosInterpreter.java
##########
@@ -133,17 +133,19 @@ private ScheduledExecutorService
startKerberosLoginThread() {
public Object call() throws Exception {
if (runKerberosLogin()) {
- logger.info("Ran runKerberosLogin command successfully.");
+ LOGGER.info("Ran runKerberosLogin command successfully.");
kinitFailCount = 0;
// schedule another kinit run with a fixed delay.
+ LOGGER.info("Scheduling Kerberos ticket refresh thread with interval
" +
+ getKerberosRefreshInterval() + " ms");
scheduledExecutorService
.schedule(this, getKerberosRefreshInterval(),
TimeUnit.MILLISECONDS);
} else {
kinitFailCount++;
- logger.info("runKerberosLogin failed for " + kinitFailCount + "
time(s).");
+ LOGGER.info("runKerberosLogin failed for " + kinitFailCount + "
time(s).");
Review comment:
Please use the parameterized message.
http://www.slf4j.org/faq.html#logging_performance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
