Reamer commented on a change in pull request #4003:
URL: https://github.com/apache/zeppelin/pull/4003#discussion_r550970517
##########
File path:
spark/interpreter/src/main/java/org/apache/zeppelin/spark/SparkSqlInterpreter.java
##########
@@ -115,14 +115,23 @@ public InterpreterResult internalInterpret(String st,
InterpreterContext context
context.out.flush();
return new InterpreterResult(Code.ERROR);
} else {
+ LOGGER.error("Error happens in sql: " + curSql, e);
Review comment:
~You are right.~
##########
File path:
spark/interpreter/src/main/java/org/apache/zeppelin/spark/SparkSqlInterpreter.java
##########
@@ -115,14 +115,23 @@ public InterpreterResult internalInterpret(String st,
InterpreterContext context
context.out.flush();
return new InterpreterResult(Code.ERROR);
} else {
+ LOGGER.error("Error happens in sql: " + curSql, e);
Review comment:
Hi @zjffdu,
I was a little bit confused. It is possible to use parameterised methods for
exceptions as well.
Checkout: http://www.slf4j.org/faq.html#paramException
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
