[GitHub] [zeppelin] Reamer commented on a change in pull request #4037: [ZEPPELIN-5218]. Don't exit shell interpreter if there's more logging produced

[GitBox]

Reamer commented on a change in pull request #4037:
URL: https://github.com/apache/zeppelin/pull/4037#discussion_r568462774



##########
File path: shell/src/main/java/org/apache/zeppelin/shell/ShellInterpreter.java
##########
@@ -78,6 +106,10 @@ public void close() {
         }
       }
     }
+
+    if (shellOutputCheckExecutor != null) {
+      shellOutputCheckExecutor.shutdownNow();

Review comment:
       The utility class 
[`ExecutorUtil`](https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/util/ExecutorUtil.java)
 provides a way to gently shut down this executor.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org