Kimahriman commented on a change in pull request #4059:
URL: https://github.com/apache/zeppelin/pull/4059#discussion_r579826864
##########
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/ShiroAuthenticationService.java
##########
@@ -138,8 +139,8 @@ private String extractPrincipal(Subject subject) {
@Override
public Collection<Realm> getRealmsList() {
String key = ThreadContext.SECURITY_MANAGER_KEY;
- DefaultWebSecurityManager defaultWebSecurityManager =
(DefaultWebSecurityManager) ThreadContext.get(key);
- return defaultWebSecurityManager.getRealms();
+ DefaultSecurityManager defaultSecurityManager = (DefaultSecurityManager)
ThreadContext.get(key);
Review comment:
Using a less specific class made it easier to test (hit a weird issue
trying to create a DefaultWebSecurityManager and it seemed unnecessary)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
