Reamer commented on pull request #4058: URL: https://github.com/apache/zeppelin/pull/4058#issuecomment-783221407
In general, I like the builder pattern for `ExecutionContext` and also final as a keyword for attributes in `ExecutionContext`. I also think that binding the `ExecutionContext` to a `Note` is a good idea. I see that you are changing attributes of the `ExecutionContext` such as the user. I think it would be better to create an additional method in the `ExecutionContextBuilder` that takes another `ExecutionContext` and makes a "copy". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
