Reamer commented on a change in pull request #4072:
URL: https://github.com/apache/zeppelin/pull/4072#discussion_r591270899
##########
File path: bin/interpreter.sh
##########
@@ -267,6 +276,7 @@ elif [[ "${INTERPRETER_ID}" == "flink" ]]; then
fi
+downloadInterpreterLibraries
Review comment:
> This is only necessary when interpreter is not launched in the same
host as zeppelin server.
It is quite difficult to decide whether it is necessary to transfer
libraries. If Zeppelin interpreters are started on the same machine
(Standalone), all libraries should be present and no files should be
transferred.
Checksum check before transfer:
https://github.com/apache/zeppelin/pull/4072/files#diff-126fba7fb446f22526016f2d293494f0b0d3b5ca4e44a318c93563570e636b71R101-R104
> And what if the download fail ?
If the transfer fails, we have an RPC (Thrift) problem that also leads to
other errors.
This transfer should always run and be used in all setups (Yarn, Docker,
K8s, Standalone). Unnecessary code can be removed afterwards in the Yarn and
Docker Launcher.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
