cuspymd commented on a change in pull request #4109:
URL: https://github.com/apache/zeppelin/pull/4109#discussion_r628125567
##########
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/search/LuceneSearch.java
##########
@@ -371,6 +372,7 @@ private void deleteDoc(String noteId, Paragraph p) {
* @see org.apache.zeppelin.search.Search#close()
*/
@Override
+ @PreDestroy
public void close() {
try {
indexWriter.close();
Review comment:
>
>
> The annotation
[`@PreDestroy`](https://docs.oracle.com/javaee/7/api/javax/annotation/PreDestroy.html)
doesn't have the annotation
[`@Inherited`](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/annotation/Inherited.html),
so the inheritance does not work. I will undo this change.
Perhaps the behavior is different depending on the implementation. When
tested in `spring` or `quarkus`, it works by inheriting `@PreDestroy` of the
parent class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
