zjffdu commented on a change in pull request #4121:
URL: https://github.com/apache/zeppelin/pull/4121#discussion_r634876091
##########
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/NoAuthenticationService.java
##########
@@ -30,7 +30,7 @@
import org.slf4j.LoggerFactory;
public class NoAuthenticationService implements AuthenticationService {
- private static Logger logger =
LoggerFactory.getLogger(NoAuthenticationService.class);
+ private static final Logger logger =
LoggerFactory.getLogger(NoAuthenticationService.class);
Review comment:
Rename it to be `LOGGER`, this is our convention for static final
variables.
##########
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/NoAuthenticationService.java
##########
@@ -30,7 +30,7 @@
import org.slf4j.LoggerFactory;
public class NoAuthenticationService implements AuthenticationService {
- private static Logger logger =
LoggerFactory.getLogger(NoAuthenticationService.class);
+ private static final Logger logger =
LoggerFactory.getLogger(NoAuthenticationService.class);
Review comment:
Rename it to be `LOGGER`, this is our naming convention for static final
variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
