EricGao888 commented on pull request #4130:
URL: https://github.com/apache/zeppelin/pull/4130#issuecomment-856538713


   > > > Where did you find the emoji images? I think it's better to download 
the emojis during the build and not put them all in our git repository.
   > > 
   > > 
   > > I found that unicode can be used instead of images for emojis. I think 
it's a better way.
   > 
   > Unicode should be sufficient. It would be nice if you would update your 
image.
   > 
   > LGTM
   
   Sure, will update the images just in case the unicode stuff breaks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to