zjffdu commented on a change in pull request #4155:
URL: https://github.com/apache/zeppelin/pull/4155#discussion_r659483224
##########
File path:
zeppelin-plugins/launcher/flink/src/main/java/org/apache/zeppelin/interpreter/launcher/FlinkInterpreterLauncher.java
##########
@@ -66,6 +69,30 @@ public FlinkInterpreterLauncher(ZeppelinConfiguration zConf,
RecoveryStorage rec
return envs;
}
+ // do mapping between configuration of different execution modes.
+ private void normalizeConfiguration(InterpreterLaunchContext context) {
+ Properties intpProperties = context.getProperties();
+ setNewProperty(intpProperties, "flink.jm.memory",
"jobmanager.memory.process.size", true);
+ setNewProperty(intpProperties, "flink.tm.memory",
"taskmanager.memory.process.size", true);
+ setNewProperty(intpProperties, "flink.tm.slot",
"taskmanager.numberOfTaskSlots", false);
+ setNewProperty(intpProperties, "flink.yarn.appName",
"yarn.application.name", false);
+ setNewProperty(intpProperties, "flink.yarn.queue",
"yarn.application.queue", false);
+ }
+
+ private void setNewProperty(Properties properties,
+ String oldKey,
+ String newKey,
+ boolean isMemoryProperty) {
+ String value = properties.getProperty(oldKey);
+ if (StringUtils.isNotBlank(value) && !properties.containsKey(newKey)) {
+ if (isMemoryProperty) {
+ properties.put(newKey, value + "mb");
+ } else {
+ properties.put(newKey, value);
+ }
+ }
Review comment:
Oops, you are right, I have updated the doc. It is official [flink
property](https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/deployment/config/),
user should not add unit in this property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
