Reamer commented on a change in pull request #4210:
URL: https://github.com/apache/zeppelin/pull/4210#discussion_r705422303
##########
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
##########
@@ -16,10 +16,9 @@
*/
package org.apache.zeppelin.socket;
-import com.google.common.base.Strings;
-import com.google.gson.Gson;
-import com.google.gson.GsonBuilder;
-import com.google.gson.reflect.TypeToken;
+import shaded.com.google.gson.Gson;
+import shaded.com.google.gson.GsonBuilder;
+import shaded.com.google.gson.reflect.TypeToken;
Review comment:
You are right. Perhaps I was a bit too hasty.
More generally, I see a problem with the Guava lib, which exists as a
transitive dependency in different versions. That's why I opened #4217.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
