Reamer commented on a change in pull request #4252:
URL: https://github.com/apache/zeppelin/pull/4252#discussion_r740131720



##########
File path: 
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java
##########
@@ -651,5 +667,63 @@ public void updateNotePath() {
     }
   }
 
+  /**
+   * Unloads notes when reasonable amount of notes are in loaded state.
+   * Leverage a simple LRU cache for determing evictable notes. Ensure to
+   * not evict notes during save operation (dirty).

Review comment:
       In principle you are right. However, `GetNote()` always places the note 
at the beginning of the LRUCache. `GetNote()` is always called before 
information is read from a note.
   As long as the concurrent executions are below the lru cache threshold, 
there should be no problems with concurrency.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to