[GitHub] [zeppelin] Reamer commented on pull request #4273: [ZEPPELIN-5601]Make the page update after excuse the clear output paragraph action

[GitBox]

Reamer commented on pull request #4273:
URL: https://github.com/apache/zeppelin/pull/4273#issuecomment-994877951


   Hi @jasmine-song,
   I tried to verify your PR.
   If I remove
   ```
       if (!newPara.results.msg) {
         newPara.results.msg = [];
       }
   ```
   from the codebase, it is possible to clean up the paragraph, because the 
method `isUpdateRequired(oldPara: ParagraphItem, newPara: ParagraphItem)` now 
returns `true` because `isEmpty(newPara.results) !== isEmpty(oldPara.results)` 
returns `true`.
   
   Unfortunately, the paragraph is not filled after a run because 
`notebookParagraphResultComponents` is empty.
   
   I have tested the behaviour with the following commands.
   ```
   cd zeppelin-web-angular
   npm install
   SERVER_PROXY=https://my-zeppelin-server.company.com npm start
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org