[GitHub] [zeppelin] huage1994 commented on a change in pull request #4292: [ZEPPELIN-5642] Provide REST API and SDK to get noteId by notePath

[GitBox]

huage1994 commented on a change in pull request #4292:
URL: https://github.com/apache/zeppelin/pull/4292#discussion_r793444352



##########
File path: 
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java
##########
@@ -417,6 +417,11 @@ private boolean isNotePathAvailable(String notePath) {
     return true;
   }
 
+  public synchronized String getNoteIdByPath(String notePath) throws 
IOException {

Review comment:
       > why add `synchronized`?
   
   Thanks @zjffdu  for reviews.  it's been removed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org