huage1994 commented on a change in pull request #4300:
URL: https://github.com/apache/zeppelin/pull/4300#discussion_r822716162
##########
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java
##########
@@ -1012,12 +1012,12 @@ public void setNoteRevision(String noteId,
}
- public void getNotebyRevision(String noteId,
+ public Note getNotebyRevision(String noteId,
Review comment:
> Could you please put the following comment to this method.
`notebook.getNoteByRevision(...) does not use the NoteCache, so we can return a
Note object here.`
Sure! Thanks a lot for your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
