huage1994 commented on code in PR #4308: URL: https://github.com/apache/zeppelin/pull/4308#discussion_r851999215
########## zeppelin-plugins/notebookrepo/oss/src/main/java/org/apache/zeppelin/notebook/repo/OSSNotebookRepo.java: ########## @@ -17,43 +17,33 @@ package org.apache.zeppelin.notebook.repo; -import com.aliyun.oss.OSS; -import com.aliyun.oss.OSSClientBuilder; -import com.aliyun.oss.model.CopyObjectRequest; -import com.aliyun.oss.model.DeleteObjectsRequest; -import com.aliyun.oss.model.ListObjectsRequest; -import com.aliyun.oss.model.OSSObject; -import com.aliyun.oss.model.OSSObjectSummary; -import com.aliyun.oss.model.ObjectListing; -import com.aliyun.oss.model.PutObjectRequest; -import org.apache.commons.io.IOUtils; import org.apache.zeppelin.conf.ZeppelinConfiguration; import org.apache.zeppelin.notebook.Note; import org.apache.zeppelin.notebook.NoteInfo; +import org.apache.zeppelin.notebook.repo.storage.OSSOperator; +import org.apache.zeppelin.notebook.repo.storage.RemoteStorageOperator; import org.apache.zeppelin.user.AuthenticationInfo; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import java.io.ByteArrayInputStream; +import java.io.File; import java.io.IOException; -import java.io.InputStream; -import java.nio.charset.StandardCharsets; -import java.util.ArrayList; -import java.util.Collections; -import java.util.HashMap; -import java.util.List; -import java.util.Map; +import java.util.*; /** * NotebookRepo for Aliyun OSS (https://cn.aliyun.com/product/oss) */ -public class OSSNotebookRepo implements NotebookRepo { +public class OSSNotebookRepo implements NotebookRepoWithVersionControl { private static final Logger LOGGER = LoggerFactory.getLogger(OSSNotebookRepo.class); - private OSS ossClient; private String bucketName; private String rootFolder; + private static int NOTE_MAX_VERSION_NUM; Review Comment: I have deleted `static`. Firstly I wanted to use final `private final static int NOTE_MAX_VERSION_NUM` , but found `final` cannot be used. Then I delete `final` but didn't delete `static`. 😬 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
