yaini commented on code in PR #4419:
URL: https://github.com/apache/zeppelin/pull/4419#discussion_r928093043
##########
zeppelin-zengine/src/test/java/org/apache/zeppelin/conf/ZeppelinConfigurationTest.java:
##########
@@ -69,18 +69,18 @@ public void getAllowedOriginsNoneTest() throws
MalformedURLException {
}
@Test
- public void isWindowsPathTestTrue() {
+ public void checkWindowsTestTrue() {
ZeppelinConfiguration conf =
ZeppelinConfiguration.create("zeppelin-test-site.xml");
- Boolean isIt = conf.isWindowsPath("c:\\test\\file.txt");
+ Boolean isIt = conf.checkWindows();
Assert.assertTrue(isIt);
}
@Test
- public void isWindowsPathTestFalse() {
+ public void checkWindowsTestFalse() {
ZeppelinConfiguration conf =
ZeppelinConfiguration.create("zeppelin-test-site.xml");
- Boolean isIt = conf.isWindowsPath("~/test/file.xml");
+ Boolean isIt = conf.checkWindows();
Assert.assertFalse(isIt);
}
Review Comment:
Previously written tests were checked using file paths, but as this function
becomes system-dependent, the meaning of the previous tests seems to have
changed.
If you write a test, it would be better to mock `checkWindows` and test the
result value of a function that uses `checkWindows`, such as `getAbsoluteDir`
and `getKeyStorePath` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
