Reamer commented on PR #4512: URL: https://github.com/apache/zeppelin/pull/4512#issuecomment-1324873754
> I think we already have a version number in our jars. Currently I see for zeppelin-common only the following information inside `MANIFEST.MF`. Is this information sufficient? ``` Specification-Title: Zeppelin: Common Specification-Version: 0.11 Specification-Vendor: The Apache Software Foundation Implementation-Title: Zeppelin: Common Implementation-Version: 0.11.0-SNAPSHOT Implementation-Vendor: The Apache Software Foundation ``` versus git.properties ``` #Generated by Git-Commit-Id-Plugin #Wed Nov 23 11:44:29 CET 2022 git.branch=master git.build.host=l-pdallig-moa git.build.time=2022-11-23 11\:44\:29 git.build.user.email=philipp.dal...@gmail.com git.build.user.name=Philipp Dallig git.build.version=0.11.0-SNAPSHOT git.closest.tag.commit.count= git.closest.tag.name= git.commit.id=bc810c324aadf472049d1e3ce95b3b1ee53edf5f git.commit.id.abbrev=bc810c3 git.commit.id.describe=bc810c3-dirty git.commit.id.describe-short=bc810c3-dirty git.commit.message.full=[ZEPPELIN-5849] MIGRATE JDBC MODULE TO JUNIT 5 (\#4511) git.commit.message.short=[ZEPPELIN-5849] MIGRATE JDBC MODULE TO JUNIT 5 (\#4511) git.commit.time=2022-11-22 13\:43\:33 git.commit.user.email=guanhua...@foxmail.com git.commit.user.name=Guanhua Li git.dirty=true git.local.branch.ahead=0 git.local.branch.behind=0 git.remote.origin.url=Unknown git.tags= git.total.commit.count=5187 ``` > Do you still think we'd better include those information in all jars? In general, I don't need the git information. But for others this could be useful. > And I thought the git.properties is being only in some API only. I have not seen the use of the file for the API yet. I'll have a look right now to see if I can find the post. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
