Reamer commented on code in PR #4509:
URL: https://github.com/apache/zeppelin/pull/4509#discussion_r1030321400
##########
pom.xml:
##########
@@ -1432,24 +1431,6 @@
</configuration>
</plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-remote-resources-plugin</artifactId>
- <executions>
- <execution>
- <id>process-remote-resources</id>
- <goals>
- <goal>process</goal>
- </goals>
- <configuration>
- <resourceBundles>
-
<resourceBundle>org.apache:apache-jar-resource-bundle:1.0</resourceBundle>
- </resourceBundles>
- </configuration>
- </execution>
- </executions>
- </plugin>
-
Review Comment:
I think it is fine to remove this extra step in Zeppelin's pom.xml, since
the execution in each Zeppelin module is triggered due to Zeppelin's parent
project `maven-apache-parent`.
Take a look into
https://github.com/apache/maven-apache-parent/blob/apache-26/pom.xml#L316-L333
Due to the global execution, the license is still stored in the JARs and
nothing changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
