Reamer commented on code in PR #4532:
URL: https://github.com/apache/zeppelin/pull/4532#discussion_r1043276481
##########
zeppelin-zengine/src/test/java/org/apache/zeppelin/conf/ZeppelinConfigurationTest.java:
##########
@@ -46,66 +46,66 @@ public void getAllowedOrigins2Test() throws
MalformedURLException {
ZeppelinConfiguration conf =
ZeppelinConfiguration.create("test-zeppelin-site2.xml");
List<String> origins = conf.getAllowedOrigins();
- Assert.assertEquals(2, origins.size());
- Assert.assertEquals("http://onehost:8080";, origins.get(0));
- Assert.assertEquals("http://otherhost.com";, origins.get(1));
+ Assertions.assertEquals(2, origins.size());
Review Comment:
Trivia. I would prefer just `assertEquals` without `Assert` or `Assertion`.
You have already imported assertEquals statically above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
